tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py - Issue 449753002: Improve error reporting when indexing tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py

Issue 449753002: Improve error reporting when indexing tab. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments explain what to do with exceptions Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py b/tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py

index 2f7385ee197d89bb8cb0692afaa8472b00933932..9301030b791ca760b9b236729270fcb0c57903f9 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/inspector_backend_list.py

@@ -45,11 +45,10 @@ class InspectorBackendList(collections.Sequence):

def __getitem__(self, index):

self._Update()

if index >= len(self._inspectable_contexts_dict.keys()):

- logging.error('About to explode: _inspectable_contexts_dict.keys() = %s',

- repr({

- "index": index,

- "keys": self._inspectable_contexts_dict.keys()

- }))

+ raise IndexError(

+ 'About to explode: _inspectable_contexts_dict.keys() = %s,'

+ '"index": %i' % (

+ repr(self._inspectable_contexts_dict.keys()), index))

context_id = self._inspectable_contexts_dict.keys()[index]

if context_id not in self._inspector_backend_dict:

backend = inspector_backend.InspectorBackend(