Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 449733002: Use a TestBrowserThreadBundle in WebContentsAudioInputStreamTest (Closed)

Created:
6 years, 4 months ago by Ryan Sleevi
Modified:
6 years, 4 months ago
Reviewers:
Wez
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use a TestBrowserThreadBundle in WebContentsAudioInputStreamTest BUG=395356 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290763

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M content/browser/media/capture/web_contents_audio_input_stream_unittest.cc View 1 2 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Ryan Sleevi
wez: You tend to review quickly - got time for this one? :)
6 years, 4 months ago (2014-08-07 03:35:26 UTC) #1
Wez
lgtm
6 years, 4 months ago (2014-08-07 06:19:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/449733002/1
6 years, 4 months ago (2014-08-07 06:21:19 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 07:49:36 UTC) #4
Ryan Sleevi
The CQ bit was unchecked by rsleevi@chromium.org
6 years, 4 months ago (2014-08-07 07:54:22 UTC) #5
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 4 months ago (2014-08-20 03:15:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/449733002/40001
6 years, 4 months ago (2014-08-20 03:17:10 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 04:24:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290763

Powered by Google App Engine
This is Rietveld 408576698