Add a TestBrowserThreadBundle to Shared Worker tests

Add a TestBrowserThreadBundle to Shared Worker tests

BUG=395356
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288014

[Ryan Sleevi, 2014-08-07 03:28:28]

horo: PTAL

[horo, 2014-08-07 04:29:38]

https://codereview.chromium.org/449723002/diff/1/content/browser/shared_worke...
File content/browser/shared_worker/shared_worker_instance_unittest.cc (right):

https://codereview.chromium.org/449723002/diff/1/content/browser/shared_worke...
content/browser/shared_worker/shared_worker_instance_unittest.cc:41:
TestBrowserThreadBundle thread_bundle_;
Sorry I can't understand why we need TestBrowserThreadBundle in
SharedWorkerInstanceTest.
Could you please write comments about why we need it?

[Ryan Sleevi, 2014-08-07 04:32:28]

On 2014/08/07 04:29:38, horo wrote:
>
https://codereview.chromium.org/449723002/diff/1/content/browser/shared_worke...
> File content/browser/shared_worker/shared_worker_instance_unittest.cc (right):
> 
>
https://codereview.chromium.org/449723002/diff/1/content/browser/shared_worke...
> content/browser/shared_worker/shared_worker_instance_unittest.cc:41:
> TestBrowserThreadBundle thread_bundle_;
> Sorry I can't understand why we need TestBrowserThreadBundle in
> SharedWorkerInstanceTest.
> Could you please write comments about why we need it?

The bug provides the full analysis, which was much longer to write out in here.

Your Worker tests depend on BrowserThread and MessageLoop, but they never
initialize either, thus your test environment doesn't really reflect the real
code. TestBrowserThreadBundle ensures that they are initialized properly.

[horo, 2014-08-07 04:36:21]

OK, thank you.

lgtm.

[Ryan Sleevi, 2014-08-07 04:39:48]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2014-08-07 04:40:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rsleevi@chromium.org/449723002/1

[commit-bot: I haz the power, 2014-08-07 08:27:53]

Change committed as 288014