Issue 449683002: Blink API to convert v8::Object to WebNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 449683002: Blink API to convert v8::Object to WebNode (Closed)

Created:
6 years, 4 months ago by Fady Samuel

Modified:
6 years, 4 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Blink API to convert v8::Object to WebNode BUG=

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	Source/web/WebBindings.cpp	View		2 chunks	+19 lines, -0 lines	0 comments	Download
	M	public/web/WebBindings.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

6 years, 4 months ago (2014-08-06 23:20:11 UTC) #1

As discussed over email, not lgtm

We don't want embedders to convert from v8::Values to web types.  Instead, you
should do this work in C++, where you're more like to get the correct answer.

Expand Messages | Collapse Messages