Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4232)

Unified Diff: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc

Issue 449673002: Provide localizable strings for Easy Unlock success notification. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
diff --git a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
index 95e938af897e593e6e90e16529601111e8500041..3680dc2202cbd0424d0cdb656edc62b55cb19974 100644
--- a/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
+++ b/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
@@ -62,19 +62,31 @@ bool EasyUnlockPrivateGetStringsFunction::RunSync() {
// TODO(isherman): Set an appropriate device name for non-ChromeOS devices.
const base::string16 device_type = base::ASCIIToUTF16("Chromeschnozzle");
#endif // defined(OS_CHROMEOS)
+
+ // Setup notification strings.
strings->SetString(
- "notificationTitle",
- l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_NOTIFICATION_TITLE,
+ "setupNotificationTitle",
+ l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_SETUP_NOTIFICATION_TITLE,
device_type));
strings->SetString(
- "notificationMessage",
- l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_NOTIFICATION_MESSAGE,
+ "setupNotificationMessage",
+ l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_SETUP_NOTIFICATION_MESSAGE,
device_type));
strings->SetString(
- "notificationButtonTitle",
- l10n_util::GetStringUTF16(IDS_EASY_UNLOCK_NOTIFICATION_BUTTON_TITLE));
+ "setupNotificationButtonTitle",
+ l10n_util::GetStringUTF16(
+ IDS_EASY_UNLOCK_SETUP_NOTIFICATION_BUTTON_TITLE));
- // Set-up dialog strings.
+ // Success notification strings.
+ strings->SetString(
+ "successNotificationTitle",
+ l10n_util::GetStringUTF16(IDS_EASY_UNLOCK_SUCCESS_NOTIFICATION_TITLE));
+ strings->SetString(
+ "successNotificationMessage",
+ l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_SUCCESS_NOTIFICATION_MESSAGE,
+ device_type));
+
+ // Setup dialog strings.
// Step 1: Intro.
strings->SetString(
"setupIntroHeaderTitle",
@@ -153,6 +165,20 @@ bool EasyUnlockPrivateGetStringsFunction::RunSync() {
l10n_util::GetStringFUTF16(
IDS_EASY_UNLOCK_SETUP_ERROR_CONNECTING_TO_PHONE, device_type));
+ // TODO(isherman): Remove these strings once the app has been updated.
+ strings->SetString(
+ "notificationTitle",
+ l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_SETUP_NOTIFICATION_TITLE,
+ device_type));
+ strings->SetString(
+ "notificationMessage",
+ l10n_util::GetStringFUTF16(IDS_EASY_UNLOCK_SETUP_NOTIFICATION_MESSAGE,
+ device_type));
+ strings->SetString(
+ "notificationButtonTitle",
+ l10n_util::GetStringUTF16(
+ IDS_EASY_UNLOCK_SETUP_NOTIFICATION_BUTTON_TITLE));
+
SetResult(strings.release());
return true;
}
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698