Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 449673002: Provide localizable strings for Easy Unlock success notification. (Closed)

Created:
6 years, 4 months ago by Ilya Sherman
Modified:
6 years, 4 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Provide localizable strings for Easy Unlock success notification. BUG=400948 TEST=none R=tengs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 2 chunks +33 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
6 years, 4 months ago (2014-08-06 22:10:24 UTC) #1
Tim Song
lgtm
6 years, 4 months ago (2014-08-06 22:16:40 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 4 months ago (2014-08-06 22:25:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/449673002/1
6 years, 4 months ago (2014-08-06 22:28:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-07 03:26:27 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 07:26:38 UTC) #6
Message was sent while issue was closed.
Change committed as 287986

Powered by Google App Engine
This is Rietveld 408576698