chrome/browser/ui/webui/help/help_ui.cc - Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/help_ui.cc

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/help/help_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/help/help_ui.cc

diff --git a/chrome/browser/ui/webui/help/help_ui.cc b/chrome/browser/ui/webui/help/help_ui.cc

index c5180daf815ec9cf52a3ee5ba5bd937d6b9b20b4..50046168ac6ab8eaab8e1ae0078a42b61ba88822 100644

--- a/chrome/browser/ui/webui/help/help_ui.cc

+++ b/chrome/browser/ui/webui/help/help_ui.cc

@@ -36,7 +36,9 @@ HelpUI::HelpUI(content::WebUI* web_ui)

content::WebUIDataSource* source = CreateAboutPageHTMLSource();

HelpHandler* handler = new HelpHandler();

- handler->GetLocalizedValues(source);

+ base::DictionaryValue localized_strings;

+ HelpHandler::GetLocalizedValues(&localized_strings);

+ source->AddLocalizedStrings(localized_strings);

content::WebUIDataSource::Add(profile, source);

web_ui->AddMessageHandler(handler);

}