Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2253)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/options_bundle.js ('k') | chrome/browser/ui/webui/help/help_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index 2c8ec46a6271fc15bdb5b4eda2bbab7e9a2f7524..b4acde4a309c4fe289404975b988658dac5d0de6 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -390,8 +390,13 @@ WebUIFactoryFunction GetWebUIFactoryFunction(WebUI* web_ui,
if (url.host() == chrome::kChromeUIQuotaInternalsHost)
return &NewWebUI<QuotaInternalsUI>;
// Settings are implemented with native UI elements on Android.
- if (url.host() == chrome::kChromeUISettingsFrameHost)
+ // Handle chrome://settings if settings in a window and about in settings
+ // are enabled.
+ if (url.host() == chrome::kChromeUISettingsFrameHost ||
+ (url.host() == chrome::kChromeUISettingsHost &&
+ ::switches::AboutInSettingsEnabled())) {
return &NewWebUI<options::OptionsUI>;
+ }
if (url.host() == chrome::kChromeUISuggestionsInternalsHost)
return &NewWebUI<SuggestionsInternalsUI>;
if (url.host() == chrome::kChromeUISyncFileSystemInternalsHost)
« no previous file with comments | « chrome/browser/resources/options/options_bundle.js ('k') | chrome/browser/ui/webui/help/help_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698