Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2506)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.cc
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc
index 7878b2574b6f1549a0723cbe1da206a86963382f..c7479866544a270455b0346bdaaeb3a16fe49a4a 100644
--- a/chrome/browser/browser_about_handler.cc
+++ b/chrome/browser/browser_about_handler.cc
@@ -10,6 +10,7 @@
#include "base/strings/string_util.h"
#include "chrome/browser/lifetime/application_lifetime.h"
#include "chrome/browser/ui/browser_dialogs.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/url_constants.h"
#include "components/url_fixer/url_fixer.h"
@@ -59,12 +60,22 @@ bool WillHandleBrowserAboutURL(GURL* url,
#endif
// Redirect chrome://settings
} else if (host == chrome::kChromeUISettingsHost) {
- host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUISettingsHost + url->path();
+ if (::switches::AboutInSettingsEnabled()) {
+ host = chrome::kChromeUISettingsFrameHost;
+ } else {
+ host = chrome::kChromeUIUberHost;
+ path = chrome::kChromeUISettingsHost + url->path();
+ }
// Redirect chrome://help
} else if (host == chrome::kChromeUIHelpHost) {
- host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIHelpHost + url->path();
+ if (::switches::AboutInSettingsEnabled()) {
+ host = chrome::kChromeUISettingsFrameHost;
+ if (url->path().empty() || url->path() == "/")
+ path = chrome::kChromeUIHelpHost;
+ } else {
+ host = chrome::kChromeUIUberHost;
+ path = chrome::kChromeUIHelpHost + url->path();
+ }
}
GURL::Replacements replacements;
« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698