Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: chrome/browser/ui/webui/options/settings_format_browsertest.js

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: simplify Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/settings_format_browsertest.js
diff --git a/chrome/browser/ui/webui/options/settings_format_browsertest.js b/chrome/browser/ui/webui/options/settings_format_browsertest.js
index 961a67e1a078552afb0ef85e66c2640fbe9a4937..ffbdf9b361cf7a6fd9b30ef4f91ee661d8d1b4e2 100644
--- a/chrome/browser/ui/webui/options/settings_format_browsertest.js
+++ b/chrome/browser/ui/webui/options/settings_format_browsertest.js
@@ -19,7 +19,15 @@ SettingsFormatWebUITest.Filters = {
* Input methods use inputMethodId instead of id for unique identification.
*/
'pref': ['language-options-input-method-template',
- 'language-options-input-method-list']
+ 'language-options-input-method-list'],
+ /**
+ * Exemption for checkboxes or radio buttons that do not require the class
+ * 'checkbox' or 'radio'.
+ * The About overlay comes from the About page and uses a different style.
+ */
+ 'style': ['channel-change-page-beta-option',
+ 'channel-change-page-dev-option',
+ 'channel-change-page-stable-option'],
Dan Beam 2014/08/13 17:03:18 eh, just change the CSS like you did
michaelpg 2014/08/13 20:17:51 Done.
};
/**
@@ -123,8 +131,10 @@ TEST_F('SettingsFormatWebUITest', 'RadioCheckboxStyleCheck', function() {
assertTrue(elements.length > 0);
for (var i = 0; i < elements.length; i++) {
var element = elements[i];
- if (!findAncestorByClass(element, element.type))
+ if (!this.isExempt(element, SettingsFormatWebUITest.Filters['style']) &&
+ !findAncestorByClass(element, element.type)) {
this.fail('MISSING_CHECK_WRAPPER', element, element.type);
+ }
}
});

Powered by Google App Engine
This is Rietveld 408576698