Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2672)

Unified Diff: chrome/browser/resources/options/search_page.js

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/search_page.js
diff --git a/chrome/browser/resources/options/search_page.js b/chrome/browser/resources/options/search_page.js
index 0152017b9fae2c119308020c7dd6905107ba86ef..204ac2cdfa4d42b6c703cd86eb4e1ab333c3a896 100644
--- a/chrome/browser/resources/options/search_page.js
+++ b/chrome/browser/resources/options/search_page.js
@@ -157,22 +157,23 @@ cr.define('options', function() {
/**
* Called after this page has shown.
+ * @override
*/
didShowPage: function() {
- // This method is called by the Options page after all pages have
- // had their visibilty attribute set. At this point we can perform the
- // search specific DOM manipulation.
+ // This method is called by PageManager after all pages have had their
+ // visibility attribute set. At this point we can perform the
+ // search-specific DOM manipulation.
this.setSearchActive_(true);
},
/**
* Called before this page will be hidden.
+ * @override
*/
willHidePage: function() {
- // This method is called by the Options page before all pages have
- // their visibilty attribute set. Before that happens, we need to
- // undo the search specific DOM manipulation that was performed in
- // didShowPage.
+ // This method is called by PageManager before all pages have had their
+ // visibility attribute set. Before that happens, we need to undo the
+ // search-specific DOM manipulation that was performed in didShowPage.
this.setSearchActive_(false);
},

Powered by Google App Engine
This is Rietveld 408576698