Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2811)

Unified Diff: chrome/browser/ui/webui/options/options_ui.cc

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: About in Settings Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/options_ui.cc
diff --git a/chrome/browser/ui/webui/options/options_ui.cc b/chrome/browser/ui/webui/options/options_ui.cc
index c7784e8cbbc94459b2cfed88a835a272e197f630..63c4aaed93cd691fd4f056eac6bea41b99c10dd3 100644
--- a/chrome/browser/ui/webui/options/options_ui.cc
+++ b/chrome/browser/ui/webui/options/options_ui.cc
@@ -33,6 +33,7 @@
#include "chrome/browser/ui/webui/options/create_profile_handler.h"
#include "chrome/browser/ui/webui/options/font_settings_handler.h"
#include "chrome/browser/ui/webui/options/handler_options_handler.h"
+#include "chrome/browser/ui/webui/options/help_overlay_handler.h"
#include "chrome/browser/ui/webui/options/home_page_overlay_handler.h"
#include "chrome/browser/ui/webui/options/import_data_handler.h"
#include "chrome/browser/ui/webui/options/language_dictionary_overlay_handler.h"
@@ -273,6 +274,7 @@ OptionsUI::OptionsUI(content::WebUI* web_ui)
#if defined(ENABLE_GOOGLE_NOW)
AddOptionsPageUIHandler(localized_strings, new GeolocationOptionsHandler());
#endif
+ AddOptionsPageUIHandler(localized_strings, new HelpOverlayHandler());
Dan Beam 2014/08/07 22:36:16 why isn't this added only on ChromeOS?
michaelpg 2014/08/08 01:10:46 Done. (The only other thing to mention is I intent
Dan Beam 2014/08/08 02:39:13 are there immediate plans to use any of the "about
stevenjb 2014/08/08 16:41:32 The plan of record is to try settings-in-a-window
AddOptionsPageUIHandler(localized_strings, new HomePageOverlayHandler());
AddOptionsPageUIHandler(localized_strings,
new MediaDevicesSelectionHandler());

Powered by Google App Engine
This is Rietveld 408576698