Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 449623003: Integrate About page into Settings for Chrome OS settings in a window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: About in Settings Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index eda517b26396e7a3098c762b17c98f6d1b588502..ada22a694d063d8b59250af505fd69305eb05b9d 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -123,6 +123,15 @@ cr.define('options', function() {
$('advanced-settings').addEventListener('webkitTransitionEnd',
this.updateAdvancedSettingsExpander_.bind(this));
+ if (cr.isChromeOS && loadTimeData.getBoolean('showVersion')) {
+ $('version-button').hidden = false;
+ $('version-button').addEventListener('click', function() {
+ PageManager.showPageByName('help');
+ chrome.send('coreOptionsUserMetricsAction',
+ ['Options_About']);
+ });
+ }
+
if (cr.isChromeOS) {
UIAccountTweaks.applyGuestSessionVisibility(document);
UIAccountTweaks.applyPublicSessionVisibility(document);

Powered by Google App Engine
This is Rietveld 408576698