Integrate About page into Settings for Chrome OS settings in a window.

chrome/browser/ui/webui/options/settings_format_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * TestFixture for testing the formatting of settings pages.
  * @extends {testing.Test}
  * @constructor
  */
 function SettingsFormatWebUITest() {}
 
 /**
  * Map of rule exemptions grouped by test.
  * @const
  */
 SettingsFormatWebUITest.Filters = {
   /**
    * Exemption for checkboxes that do not require an id or pref property.
    * Input methods use inputMethodId instead of id for unique identification.
    */
   'pref': ['language-options-input-method-template',
-           'language-options-input-method-list']
+           'language-options-input-method-list'],
+  /**
+   * Exemption for checkboxes or radio buttons that do not require the class
+   * 'checkbox' or 'radio'.
+   * The About overlay comes from the About page and uses a different style.
+   */
+  'style': ['channel-change-page-beta-option',
+            'channel-change-page-dev-option',
+            'channel-change-page-stable-option'],

[Dan Beam, 2014/08/13 17:03:18]

eh, just change the CSS like you did

[michaelpg, 2014/08/13 20:17:51]

Done.

 };
 
 /**
  * Collection of error messages.
  * @const
  */
 SettingsFormatWebUITest.Messages = {
     MISSING_CHECK_WRAPPER: 'Element $1 should be enclosed in <div class="$2">',
     MISSING_ID_OR_PREF: 'Missing id or pref preoperty for checkbox $1.',
     MISSING_RADIO_BUTTON_NAME: 'Radio button $1 is missing the name property',
@@ skipping 83 matching lines @@
  * Ensure that radio and checkbox buttons have consistent layout.
  */
 TEST_F('SettingsFormatWebUITest', 'RadioCheckboxStyleCheck', function() {
   var settings = $('settings');
   assertTrue(settings != null, 'Unable to access settings');
   var query = 'input[type=checkbox], input[type=radio]';
   var elements = document.querySelectorAll(query);
   assertTrue(elements.length > 0);
   for (var i = 0; i < elements.length; i++) {
     var element = elements[i];
-    if (!findAncestorByClass(element, element.type))
+    if (!this.isExempt(element, SettingsFormatWebUITest.Filters['style']) &&
+        !findAncestorByClass(element, element.type)) {
       this.fail('MISSING_CHECK_WRAPPER', element, element.type);
+    }
   }
 });
 
 /**
  * Each checkbox requires an id or pref property.
  */
 TEST_F('SettingsFormatWebUITest', 'CheckboxIdOrPrefCheck', function() {
   var query = 'input[type=checkbox]:not([pref]):not([id])';
   var elements = document.querySelectorAll(query);
   for (var i = 0; i < elements.length; i++) {
@@ skipping 10 matching lines @@
   var elements = document.querySelectorAll('input[type=radio]');
   for (var i = 0; i < elements.length; i++) {
     var element = elements[i];
     if (!element.name)
       this.fail('MISSING_RADIO_BUTTON_NAME', element);
 
     if (!element.getAttribute('value'))
       this.fail('MISSING_RADIO_BUTTON_VALUE', element);
   }
 });