Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 449543002: Supervised users: Add prefs for a secondary custodian, and for the custodian's profile image URL. (Closed)

Created:
6 years, 4 months ago by Marc Treib
Modified:
6 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Supervised users: Add prefs for a secondary custodian, and for the custodian's profile image URL. BUG=372381 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 2 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Marc Treib
Up for discussion: I added a second set of prefs. Alternatively, we could replace the ...
6 years, 4 months ago (2014-08-06 16:32:07 UTC) #1
Bernhard Bauer
LGTM
6 years, 4 months ago (2014-08-07 14:56:48 UTC) #2
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-07 14:58:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/449543002/1
6 years, 4 months ago (2014-08-07 14:59:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-07 18:03:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 18:51:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/4256)
6 years, 4 months ago (2014-08-07 18:51:38 UTC) #7
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 4 months ago (2014-08-08 00:19:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/449543002/1
6 years, 4 months ago (2014-08-08 00:54:34 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 06:45:51 UTC) #10
Message was sent while issue was closed.
Change committed as 288235

Powered by Google App Engine
This is Rietveld 408576698