Fix MediaDrmBridgeTest.IsKeySystemSupported_Widevine test.

Fix MediaDrmBridgeTest.IsKeySystemSupported_Widevine test.

BUG=401092
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287840

[xhwang, 2014-08-06 16:52:13]

I didn't test it but I think it should work ;) PTAL

[anton1, 2014-08-06 17:35:12]

On 2014/08/06 16:52:13, xhwang wrote:
> I didn't test it but I think it should work ;) PTAL

lgtm. I have tested on Arm64 (but not on Arm32).

[anton1, 2014-08-06 17:38:38]

+rmcilroy

[rmcilroy, 2014-08-06 17:46:08]

lgtm

https://codereview.chromium.org/449523003/diff/1/media/base/android/media_drm...
File media/base/android/media_drm_bridge_unittest.cc (right):

https://codereview.chromium.org/449523003/diff/1/media/base/android/media_drm...
media/base/android/media_drm_bridge_unittest.cc:78: if
(base::android::BuildInfo::GetInstance()->sdk_int() <= 19) {
Note, this is not absolutely correct (the 'L' release hasn't got an API version
yet and is still using the previous API version).  We get away with it here
because API 20 was never released on phones/tablets, so we can use it.  The
correct approach is to check for Build.CODE == 'L' until 'L' get's an official
API version, but this doesn't seem to be available in C++, so I'm fine with
going for this now since it's only for a test.

[xhwang, 2014-08-06 17:55:31]

On 2014/08/06 17:46:08, rmcilroy wrote:
> lgtm
> 
>
https://codereview.chromium.org/449523003/diff/1/media/base/android/media_drm...
> File media/base/android/media_drm_bridge_unittest.cc (right):
> 
>
https://codereview.chromium.org/449523003/diff/1/media/base/android/media_drm...
> media/base/android/media_drm_bridge_unittest.cc:78: if
> (base::android::BuildInfo::GetInstance()->sdk_int() <= 19) {
> Note, this is not absolutely correct (the 'L' release hasn't got an API
version
> yet and is still using the previous API version).  We get away with it here
> because API 20 was never released on phones/tablets, so we can use it.  The
> correct approach is to check for Build.CODE == 'L' until 'L' get's an official
> API version, but this doesn't seem to be available in C++, so I'm fine with
> going for this now since it's only for a test.

Thanks for the explanations!

I don't understand how API level is assigned, but I do see "20" in this
documentation:
https://developer.android.com/preview/setup-sdk.html

[xhwang, 2014-08-06 17:55:37]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2014-08-06 17:57:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xhwang@chromium.org/449523003/1

[commit-bot: I haz the power, 2014-08-06 20:06:30]

Change committed as 287840