Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 449483002: Document pixel dimension limit for WallpaperImage policy. (Closed)

Created:
6 years, 4 months ago by Thiemo Nagel
Modified:
6 years, 4 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Document pixel dimension limit for WallpaperImage policy. BUG=366825 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287816

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address Bartosz' comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/policy/resources/policy_templates.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Thiemo Nagel
Hi Bartosz, could you please take a look? Thank you! Thiemo
6 years, 4 months ago (2014-08-06 14:23:17 UTC) #1
bartfab (slow)
lgtm https://codereview.chromium.org/449483002/diff/20001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/449483002/diff/20001/components/policy/resources/policy_templates.json#newcode6512 components/policy/resources/policy_templates.json:6512: This policy allows you to configure the wallpaper ...
6 years, 4 months ago (2014-08-06 14:35:45 UTC) #2
Thiemo Nagel
Thank you! https://codereview.chromium.org/449483002/diff/20001/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/449483002/diff/20001/components/policy/resources/policy_templates.json#newcode6512 components/policy/resources/policy_templates.json:6512: This policy allows you to configure the ...
6 years, 4 months ago (2014-08-06 15:23:56 UTC) #3
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 4 months ago (2014-08-06 15:23:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/449483002/40001
6 years, 4 months ago (2014-08-06 15:24:56 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 18:53:25 UTC) #6
Message was sent while issue was closed.
Change committed as 287816

Powered by Google App Engine
This is Rietveld 408576698