Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 449433003: Fix drawVertices() on GPU when texs=colors=shaders=indices=null (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix drawVertices() on GPU when texs=colors=shaders=indices=null Committed: https://skia.googlesource.com/skia/+/a098dd490cc4e434f054b7506c2f6e08f519585b

Patch Set 1 #

Patch Set 2 : remove extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
NULL shader is already checked for towards the bottom.
6 years, 4 months ago (2014-08-06 14:40:17 UTC) #1
reed1
lgtm
6 years, 4 months ago (2014-08-06 14:43:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/449433003/20001
6 years, 4 months ago (2014-08-06 14:43:37 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 18:01:50 UTC) #4
Message was sent while issue was closed.
Change committed as a098dd490cc4e434f054b7506c2f6e08f519585b

Powered by Google App Engine
This is Rietveld 408576698