Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: Source/devtools/front_end/network/NetworkPanel.js

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1509 matching lines...) Expand 10 before | Expand all | Expand 10 after
1520 if (node) { 1520 if (node) {
1521 this._dataGrid.element.focus(); 1521 this._dataGrid.element.focus();
1522 node.reveal(); 1522 node.reveal();
1523 this._highlightNode(node); 1523 this._highlightNode(node);
1524 } 1524 }
1525 }, 1525 },
1526 1526
1527 _removeAllNodeHighlights: function() 1527 _removeAllNodeHighlights: function()
1528 { 1528 {
1529 if (this._highlightedNode) { 1529 if (this._highlightedNode) {
1530 this._highlightedNode.element.classList.remove("highlighted-row"); 1530 this._highlightedNode.element().classList.remove("highlighted-row");
1531 delete this._highlightedNode; 1531 delete this._highlightedNode;
1532 } 1532 }
1533 }, 1533 },
1534 1534
1535 /** 1535 /**
1536 * @param {!WebInspector.NetworkDataGridNode} node 1536 * @param {!WebInspector.NetworkDataGridNode} node
1537 */ 1537 */
1538 _highlightNode: function(node) 1538 _highlightNode: function(node)
1539 { 1539 {
1540 WebInspector.runCSSAnimationOnce(node.element, "highlighted-row"); 1540 WebInspector.runCSSAnimationOnce(node.element(), "highlighted-row");
1541 this._highlightedNode = node; 1541 this._highlightedNode = node;
1542 }, 1542 },
1543 1543
1544 /** 1544 /**
1545 * @param {!WebInspector.NetworkRequest} request 1545 * @param {!WebInspector.NetworkRequest} request
1546 * @return {string} 1546 * @return {string}
1547 */ 1547 */
1548 _generateCurlCommand: function(request) 1548 _generateCurlCommand: function(request)
1549 { 1549 {
1550 var command = ["curl"]; 1550 var command = ["curl"];
(...skipping 1499 matching lines...) Expand 10 before | Expand all | Expand 10 after
3050 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b) 3050 WebInspector.NetworkDataGridNode.RequestPropertyComparator = function(propertyNa me, revert, a, b)
3051 { 3051 {
3052 var aValue = a._request[propertyName]; 3052 var aValue = a._request[propertyName];
3053 var bValue = b._request[propertyName]; 3053 var bValue = b._request[propertyName];
3054 if (aValue > bValue) 3054 if (aValue > bValue)
3055 return revert ? -1 : 1; 3055 return revert ? -1 : 1;
3056 if (bValue > aValue) 3056 if (bValue > aValue)
3057 return revert ? 1 : -1; 3057 return revert ? 1 : -1;
3058 return a._request.indentityCompare(b._request); 3058 return a._request.indentityCompare(b._request);
3059 } 3059 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/components/CookiesTable.js ('k') | Source/devtools/front_end/profiler/CanvasReplayStateView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698