Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: LayoutTests/inspector/profiler/heap-snapshot-test.js

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 var initialize_HeapSnapshotTest = function() { 1 var initialize_HeapSnapshotTest = function() {
2 2
3 InspectorTest.createHeapSnapshotMockFactories = function() { 3 InspectorTest.createHeapSnapshotMockFactories = function() {
4 4
5 InspectorTest.createJSHeapSnapshotMockObject = function() 5 InspectorTest.createJSHeapSnapshotMockObject = function()
6 { 6 {
7 return { 7 return {
8 _rootNodeIndex: 0, 8 _rootNodeIndex: 0,
9 _nodeTypeOffset: 0, 9 _nodeTypeOffset: 0,
10 _nodeNameOffset: 1, 10 _nodeNameOffset: 1,
(...skipping 564 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 InspectorTest.columnContents = function(column, row) 575 InspectorTest.columnContents = function(column, row)
576 { 576 {
577 // Make sure invisible nodes are removed from the view port. 577 // Make sure invisible nodes are removed from the view port.
578 this._currentGrid().updateVisibleNodes(); 578 this._currentGrid().updateVisibleNodes();
579 var columnOrdinal = InspectorTest.viewColumns().indexOf(column); 579 var columnOrdinal = InspectorTest.viewColumns().indexOf(column);
580 var result = []; 580 var result = [];
581 var parent = row || this._currentGrid().rootNode(); 581 var parent = row || this._currentGrid().rootNode();
582 for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) { 582 for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) {
583 if (!node.selectable) 583 if (!node.selectable)
584 continue; 584 continue;
585 var content = node.element.children[columnOrdinal]; 585 var content = node.element().children[columnOrdinal];
586 // Do not inlcude percents 586 // Do not inlcude percents
587 if (content.firstElementChild) 587 if (content.firstElementChild)
588 content = content.firstElementChild; 588 content = content.firstElementChild;
589 result.push(content.textContent); 589 result.push(content.textContent);
590 } 590 }
591 return result; 591 return result;
592 }; 592 };
593 593
594 InspectorTest.countDataRows = function(row, filter) 594 InspectorTest.countDataRows = function(row, filter)
595 { 595 {
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 function sortingComplete() 725 function sortingComplete()
726 { 726 {
727 dataGrid.removeEventListener(WebInspector.HeapSnapshotSortableDataGr id.Events.SortingComplete, sortingComplete, null); 727 dataGrid.removeEventListener(WebInspector.HeapSnapshotSortableDataGr id.Events.SortingComplete, sortingComplete, null);
728 callback(); 728 callback();
729 } 729 }
730 dataGrid.addEventListener(WebInspector.HeapSnapshotSortableDataGrid.Even ts.SortingComplete, sortingComplete, null); 730 dataGrid.addEventListener(WebInspector.HeapSnapshotSortableDataGrid.Even ts.SortingComplete, sortingComplete, null);
731 } 731 }
732 }; 732 };
733 733
734 }; 734 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698