Implement OzonePlatform

ui/gfx/ozone/surface_factory_ozone.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/ozone/surface_factory_ozone.h"
 
 #include <stdlib.h>
 
 #include "base/command_line.h"
 #include "ui/gfx/ozone/impl/file_surface_factory_ozone.h"
@@ skipping 28 matching lines @@
   }
 };
 
 SurfaceFactoryOzone::SurfaceFactoryOzone() {
 }
 
 SurfaceFactoryOzone::~SurfaceFactoryOzone() {
 }
 
 SurfaceFactoryOzone* SurfaceFactoryOzone::GetInstance() {
-  if (!impl_) {
-    const char kOzoneFileSurface[] = "ozone-dump-file";
-    CommandLine* cmd = CommandLine::ForCurrentProcess();
-    if (cmd->HasSwitch(kOzoneFileSurface)) {
-      base::FilePath location = cmd->GetSwitchValuePath(kOzoneFileSurface);
-      if (location.empty())
-        location = base::FilePath("/dev/null");
-      impl_ = new FileSurfaceFactoryOzone(location);
-    } else {
-      LOG(WARNING) << "No SurfaceFactoryOzone implementation set. Using default"
-                      " gfx::SoftwareSurfaceFactoryOzone.";
-      impl_ = new SoftwareSurfaceFactoryOzone();
-    }
-  }
+  CHECK(impl_) << "No SurfaceFactoryOzone implementation set.";
   return impl_;
 }
 
 void SurfaceFactoryOzone::SetInstance(SurfaceFactoryOzone* impl) {
   impl_ = impl;
 }
 
 const char* SurfaceFactoryOzone::DefaultDisplaySpec() {
   char* envvar = getenv("ASH_DISPLAY_SPEC");

[vignatti (out of this project), 2013/10/28 15:26:44]

I'm not sure we want to use this CL for fixing it, but the snip on this method
is also implementation specific and has to go away. Maybe we can define most of
SurfaceFactoryOzone methods as pure virtual?

[spang, 2013/10/28 15:42:30]

I agree this probably doesn't belong, but not for this CL ;).

   if (envvar)
     return envvar;
   return  "720x1280*2";
 }
 
 gfx::Screen* SurfaceFactoryOzone::CreateDesktopScreen() {
   return NULL;
 }
 
 intptr_t SurfaceFactoryOzone::GetNativeDisplay() {
@@ skipping 12 matching lines @@
     const int32* desired_attributes) {
   return desired_attributes;
 }
 
 // static
 SurfaceFactoryOzone* SurfaceFactoryOzone::CreateTestHelper() {
   return new SurfaceFactoryOzoneStub;
 }
 
 }  // namespace gfx