Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 449283002: Safebrowsing: grab lookup_lock_ when clearing browse_gethash_cache_ during update. (Closed)

Created:
6 years, 4 months ago by mattm
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Safebrowsing: grab lookup_lock_ when clearing browse_gethash_cache_ during update. BUG=391467 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mattm
6 years, 4 months ago (2014-08-07 23:58:34 UTC) #1
Scott Hess - ex-Googler
Indeed! LGTM
6 years, 4 months ago (2014-08-08 00:50:41 UTC) #2
mattm
The CQ bit was checked by mattm@chromium.org
6 years, 4 months ago (2014-08-08 00:54:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mattm@chromium.org/449283002/1
6 years, 4 months ago (2014-08-08 01:05:25 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 10:03:34 UTC) #5
Message was sent while issue was closed.
Change committed as 288294

Powered by Google App Engine
This is Rietveld 408576698