Rework "analysis.updateContent" analysis server request.

pkg/analysis_server/test/integration/analysis_domain_int_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.integration.analysis.domain;
 
 import 'dart:async';
 
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:path/path.dart';
@@ skipping 181 matching lines @@
     String goodText = r'''
 main() {
   print("Hello, world!");
 }''';
     String badText = goodText.replaceAll(';', '');
     writeFile(pathname, badText);
     standardAnalysisRoot();
     return analysisFinished.then((_) {
       // The contents on disk (badText) are missing a semicolon.
       expect(currentAnalysisErrors[pathname], isNot(isEmpty));
-      var contentChange = {
-        'content': goodText
-      };
+
       if (includeOffsetAndLengths) {
-        contentChange['offset'] = goodText.indexOf(';');
-        contentChange['oldLength'] = 0;
-        contentChange['newLength'] = 1;
+        // Before we send a ChangeContentOverlay directive we need to send an
+        // AddContentOverlay directive.  So send that with badText.
+        return sendAnalysisUpdateContent({
+          pathname: {
+            'type': 'add',
+            'content': badText
+          }
+        }).then((_) => analysisFinished);
       }
-      return sendAnalysisUpdateContent({
-        pathname: contentChange
-      });
+    }).then((_) {
+      if (includeOffsetAndLengths) {
+        return sendAnalysisUpdateContent({
+          pathname: {
+            'type': 'change',
+            'offset': goodText.indexOf(';'),
+            'oldLength': 0,
+            'replacement': ';'
+          }
+        });
+      } else {
+        return sendAnalysisUpdateContent({
+          pathname: {
+            'type': 'add',
+            'content': goodText
+          }
+        });
+      }
     }).then((result) => analysisFinished).then((_) {
       // There should be no errors now because the contents on disk have been
       // overriden with goodText.
       expect(currentAnalysisErrors[pathname], isEmpty);
       // TODO(paulberry): passing "checkTypes: false" to work around the fact
       // that isContentChange doesn't permit 'content' to be null.
       return sendAnalysisUpdateContent({
         pathname: {
-          'content': null
+          'type': 'remove'
         }
-      }, checkTypes: false);
+      });
     }).then((result) => analysisFinished).then((_) {
       // Now there should be errors again, because the contents on disk are no
       // longer overridden.
       expect(currentAnalysisErrors[pathname], isNot(isEmpty));
     });
   }
 }
 
 main() {
   runReflectiveTests(AnalysisDomainIntegrationTest);
 }