Source/web/WebElement.cpp - Issue 449133003: Move Web-facing fullscreen APIs to DocumentFullscreen and ElementFullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebElement.cpp

Issue 449133003: Move Web-facing fullscreen APIs to DocumentFullscreen and ElementFullscreen (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebElement.cpp

diff --git a/Source/web/WebElement.cpp b/Source/web/WebElement.cpp

index d6300d8b79c7c484ebf224f9b89d8ac968686dbb..3bb7f30150e5fbfd31ef00f966ec6055f4f35dd1 100644

--- a/Source/web/WebElement.cpp

+++ b/Source/web/WebElement.cpp

@@ -33,6 +33,7 @@

#include "bindings/core/v8/ExceptionState.h"

#include "core/dom/Element.h"

+#include "core/dom/FullscreenElementStack.h"

#include "core/dom/NamedNodeMap.h"

#include "core/dom/custom/CustomElementCallbackDispatcher.h"

#include "core/dom/shadow/ShadowRoot.h"

@@ -142,7 +143,8 @@ WebString WebElement::computeInheritedLanguage() const

void WebElement::requestFullScreen()

{

- unwrap<Element>()->webkitRequestFullScreen(Element::ALLOW_KEYBOARD_INPUT);

+ Element* element = unwrap<Element>();

+ FullscreenElementStack::from(element->document()).requestFullScreenForElement(*element, FullscreenElementStack::PrefixedMozillaAllowKeyboardInputRequest);

}

WebRect WebElement::boundsInViewportSpace()

« Source/core/dom/ElementFullscreen.idl ('K') | « Source/core/dom/ElementFullscreen.idl ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »