Move Web-facing fullscreen APIs to DocumentFullscreen and ElementFullscreen

Move Web-facing fullscreen APIs to DocumentFullscreen and ElementFullscreen

This is closer to the partial interfaces of the spec:
http://fullscreen.spec.whatwg.org/#api

As a side-effect, the prefixed functions are now only used for bindings,
forcing internal clients to pick a request type more explicitly.

BUG=383813
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179805

[philipj_slow, 2014-08-07 21:46:11]

PTAL

[falken, 2014-08-08 02:28:18]

Nice cleanup, lgtm assuming I understand. You'll also need an API OWNER to
review the IDL changes.

https://codereview.chromium.org/449133003/diff/1/Source/core/dom/ElementFulls...
File Source/core/dom/ElementFullscreen.idl (right):

https://codereview.chromium.org/449133003/diff/1/Source/core/dom/ElementFulls...
Source/core/dom/ElementFullscreen.idl:14: attribute EventHandler
onwebkitfullscreenerror;
Just to make sure I understand, these EventHandlers are not in the spec, but
this patch keeps them to not change existing behavior?

[philipj_slow, 2014-08-08 05:40:48]

https://codereview.chromium.org/449133003/diff/1/Source/core/dom/ElementFulls...
File Source/core/dom/ElementFullscreen.idl (right):

https://codereview.chromium.org/449133003/diff/1/Source/core/dom/ElementFulls...
Source/core/dom/ElementFullscreen.idl:14: attribute EventHandler
onwebkitfullscreenerror;
On 2014/08/08 02:28:18, falken wrote:
> Just to make sure I understand, these EventHandlers are not in the spec, but
> this patch keeps them to not change existing behavior?

Precisely, these were on Element.idl and I moved them here for higher
visibility, no observable change expected. The unprefixed ones won't be on
Element though, just on Document.

[philipj_slow, 2014-08-08 07:12:52]

rebase

[philipj_slow, 2014-08-08 07:14:21]

tkent, can you rubberstamp the Source/web changes?

[philipj_slow, 2014-08-08 07:57:26]

pfeldman, can you rubberstamp Source/web for me? (mkwst says in #blink that
you're in a favorable timezone)

[tkent, 2014-08-08 08:23:04]

lgtm

[philipj_slow, 2014-08-08 08:32:01]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-08-08 08:32:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/philipj@opera.com/449133003/20001

[commit-bot: I haz the power, 2014-08-08 09:06:45]

Change committed as 179805