Issue 449093002: Subzero: A few fixes toward running larger programs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 449093002: Subzero: A few fixes toward running larger programs. (Closed)

Created:
6 years, 4 months ago by Jim Stichnoth

Modified:
6 years, 4 months ago

Reviewers:
jvoung (off chromium), wala

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Subzero: A few fixes toward running larger programs. 1. Add 'llvm2ice -disable-globals' to disable Subzero translation of global initializers, since full support isn't yet implemented. 2. Change the names of intra-block branch target labels to avoid collisions with basic block labels. 3. Fix lowering of "br i1 <constant>, label ...", which was producing invalid instructions like "cmp 1, 0". 4. Fix the "make format-diff" operation, which was diffing against the wrong target. BUG= none R=wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=206833c

Patch Set 1 #

Patch Set 2 : Fix "make format-diff", and run it #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -9 lines)			Patch
M	Makefile.standalone	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceClFlags.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/IceConverter.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/IceInstX8632.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/llvm2ice.cpp	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/branch-simple.ll	View		3 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jim Stichnoth

6 years, 4 months ago (2014-08-07 17:58:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r206833c (presubmit successful).

Expand Messages | Collapse Messages