Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/cocoa/tab_strip_model_observer_bridge.mm

Issue 449056: Mac: change tab change notifications to pass full TabChangeType. (Closed)
Patch Set: Rebased ToT. Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/tab_strip_model_observer_bridge.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
diff --git a/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm b/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
index cb89accb71a38169942aac3961224e7af447b905..e3f2c02b00c449b2f0a6fd16895438fb39b4f8c7 100644
--- a/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
+++ b/chrome/browser/cocoa/tab_strip_model_observer_bridge.mm
@@ -75,16 +75,11 @@ void TabStripModelObserverBridge::TabMoved(TabContents* contents,
void TabStripModelObserverBridge::TabChangedAt(TabContents* contents,
int index,
TabChangeType change_type) {
- if (change_type == TITLE_NOT_LOADING) {
- // TODO(sky): make this work.
- // We'll receive another notification of the change asynchronously.
- return;
- }
if ([controller_ respondsToSelector:
- @selector(tabChangedWithContents:atIndex:loadingOnly:)]) {
+ @selector(tabChangedWithContents:atIndex:changeType:)]) {
[controller_ tabChangedWithContents:contents
atIndex:index
- loadingOnly:change_type == LOADING_ONLY ? YES : NO];
+ changeType:change_type];
}
}
« no previous file with comments | « chrome/browser/cocoa/tab_strip_model_observer_bridge.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698