Mac: change tab change notifications to pass full TabChangeType.

chrome/browser/cocoa/browser_window_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <Carbon/Carbon.h>
 
 #include "app/l10n_util_mac.h"
 #include "base/mac_util.h"
 #include "base/scoped_nsdisable_screen_updates.h"
 #import "base/scoped_nsobject.h"
@@ skipping 1085 matching lines @@
 }
 
 - (void)selectTabWithContents:(TabContents*)newContents
              previousContents:(TabContents*)oldContents
                       atIndex:(NSInteger)index
                   userGesture:(bool)wasUserGesture {
   DCHECK(oldContents != newContents);
 
   // Update various elements that are interested in knowing the current
   // TabContents.
-#if 0
-// TODO(pinkerton):Update as more things become window-specific
-  contents_container_->SetTabContents(newContents);
-#endif
 
   // Update all the UI bits.
   windowShim_->UpdateTitleBar();
 
-#if 0
-// TODO(pinkerton):Update as more things become window-specific
-  toolbar_->SetProfile(newContents->profile());
-  UpdateToolbar(newContents, true);
-  UpdateUIForContents(newContents);
-#endif
-
   // Update the bookmark bar.
   [self updateBookmarkBarVisibilityWithAnimation:NO];
 }
 
 - (void)tabChangedWithContents:(TabContents*)contents
                        atIndex:(NSInteger)index
-                   loadingOnly:(BOOL)loading {
+                    changeType:(TabStripModelObserver::TabChangeType)change {
   if (index == browser_->tabstrip_model()->selected_index()) {
-    // Update titles if this is the currently selected tab.
-    windowShim_->UpdateTitleBar();
+    // Update titles if this is the currently selected tab and if it isn't just
+    // the loading state which changed.
+    if (change != TabStripModelObserver::LOADING_ONLY)
+      windowShim_->UpdateTitleBar();
+
+    // Update the bookmark bar if this is the currently selected tab and if it
+    // isn't just the title which changed. This for transitions between the NTP
+    // (showing its floating bookmark bar) and normal web pages (showing no
+    // bookmark bar).
+    // TODO(viettrungluu): perhaps update to not terminate running animations?
+    if (change != TabStripModelObserver::TITLE_NOT_LOADING)
+      [self updateBookmarkBarVisibilityWithAnimation:NO];
   }
-
-  // Update the bookmark bar.
-  [self updateBookmarkBarVisibilityWithAnimation:NO];
 }
 
 - (void)userChangedTheme {
   [self setTheme];
   NSNotificationCenter* defaultCenter = [NSNotificationCenter defaultCenter];
   [defaultCenter postNotificationName:kGTMThemeDidChangeNotification
                                object:theme_];
   // TODO(dmaclach): Instead of redrawing the whole window, views that care
   // about the active window state should be registering for notifications.
   [[self window] setViewsNeedDisplay:YES];
@@ skipping 574 matching lines @@
     [theme setValue:frameOverlayInactiveImage
        forAttribute:@"overlay"
               style:GTMThemeStyleWindow
               state:GTMThemeStateInactiveWindow];
   }
 
   return theme;
 }
 @end