Adding instrument to NotificationRegistrar to check...

Adding instrument to NotificationRegistrar to check
Add() and Remove() are called from same thread.

Note I already checked in a fix for the bug. The CL
is trying to check whether the issue exists in other
code path.

TEST=none
BUG=27834
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33802

[eroman, 2009-12-01 04:16:37]

Pity you can't use the base/not_thread_safe.h base class, since that is
basically what you want (but it is only enabled in DEBUG mode).

Also note the try jobs failed :)

otherwise lgtm

http://codereview.chromium.org/449044/diff/1/2
File chrome/common/notification_registrar.cc (right):

http://codereview.chromium.org/449044/diff/1/2#newcode71
chrome/common/notification_registrar.cc:71: if (thread_id_ !=
ChromeThread::ID_COUNT) {
How about creating a helper function, similar to NotThreadSafe's
CalledOnValidThread() ?

[huanr, 2009-12-03 02:24:59]

Updated. Can you take another look?

[eroman, 2009-12-04 00:57:35]

lgtm

http://codereview.chromium.org/449044/diff/7001/6005
File chrome/browser/chrome_thread.cc (right):

http://codereview.chromium.org/449044/diff/7001/6005#newcode65
chrome/browser/chrome_thread.cc:65: return !!chrome_threads_[identifier];
minor style-nit:

could group it into one line:

return (identifier >= 0 && identifier < ID_COUNT &&
chrome_threads_[identifier]);