Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: content/browser/devtools/renderer_overrides_handler_browsertest.cc

Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/renderer_overrides_handler_browsertest.cc
diff --git a/content/browser/devtools/renderer_overrides_handler_browsertest.cc b/content/browser/devtools/renderer_overrides_handler_browsertest.cc
index 2a3a667c03ccfc5b21ded4f02c5f877ba2ce31a4..35a8fffac7a18e66a66ebe7734927b49ae496a4b 100644
--- a/content/browser/devtools/renderer_overrides_handler_browsertest.cc
+++ b/content/browser/devtools/renderer_overrides_handler_browsertest.cc
@@ -7,8 +7,6 @@
#include "base/json/json_reader.h"
#include "content/browser/devtools/devtools_protocol.h"
#include "content/public/browser/devtools_agent_host.h"
-#include "content/public/browser/devtools_client_host.h"
-#include "content/public/browser/devtools_manager.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/content_browser_test.h"
@@ -20,12 +18,12 @@
namespace content {
class RendererOverridesHandlerTest : public ContentBrowserTest,
- public DevToolsClientHost {
+ public DevToolsAgentHost::Client {
protected:
void SendCommand(const std::string& method,
base::DictionaryValue* params) {
- EXPECT_TRUE(DevToolsManager::GetInstance()->DispatchOnInspectorBackend(this,
- DevToolsProtocol::CreateCommand(1, method, params)->Serialize()));
+ agent_host_->DispatchOnInspectorBackend(
+ DevToolsProtocol::CreateCommand(1, method, params)->Serialize());
base::MessageLoop::current()->Run();
}
@@ -55,21 +53,22 @@ class RendererOverridesHandlerTest : public ContentBrowserTest,
}
scoped_ptr<base::DictionaryValue> result_;
+ scoped_refptr<DevToolsAgentHost> agent_host_;
private:
virtual void SetUpOnMainThread() OVERRIDE {
- DevToolsManager::GetInstance()->RegisterDevToolsClientHostFor(
- DevToolsAgentHost::GetOrCreateFor(
- shell()->web_contents()->GetRenderViewHost()).get(),
- this);
+ agent_host_ = DevToolsAgentHost::GetOrCreateFor(
+ shell()->web_contents()->GetRenderViewHost());
+ agent_host_->AttachClient(this);
}
virtual void TearDownOnMainThread() OVERRIDE {
- DevToolsManager::GetInstance()->ClientHostClosing(this);
+ agent_host_->DetachClient();
+ agent_host_ = NULL;
}
- virtual void DispatchOnInspectorFrontend(
- const std::string& message) OVERRIDE {
+ virtual void DispatchProtocolMessage(
+ DevToolsAgentHost* agent_host, const std::string& message) OVERRIDE {
scoped_ptr<base::DictionaryValue> root(
static_cast<base::DictionaryValue*>(base::JSONReader::Read(message)));
base::DictionaryValue* result;
@@ -78,11 +77,8 @@ class RendererOverridesHandlerTest : public ContentBrowserTest,
base::MessageLoop::current()->QuitNow();
}
- virtual void InspectedContentsClosing() OVERRIDE {
- EXPECT_TRUE(false);
- }
-
- virtual void ReplacedWithAnotherClient() OVERRIDE {
+ virtual void AgentHostClosed(
+ DevToolsAgentHost* agent_host, bool replaced) OVERRIDE {
EXPECT_TRUE(false);
}
};

Powered by Google App Engine
This is Rietveld 408576698