chrome/browser/ui/browser.cc - Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/debugger/debugger_api.cc ('K') | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller_browsertest.mm » ('j') | content/browser/devtools/devtools_agent_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 2f13de8372f21a272f767d3c15305eab8e65df8c..ac3ae9c8ad88cdf4803efad56f9a75909bbaa99e 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -156,7 +156,7 @@

#include "components/startup_metric_utils/startup_metric_utils.h"

#include "components/web_modal/popup_manager.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

-#include "content/public/browser/devtools_manager.h"

+#include "content/public/browser/devtools_agent_host.h"

#include "content/public/browser/download_item.h"

#include "content/public/browser/download_manager.h"

#include "content/public/browser/interstitial_page.h"

@@ -2028,7 +2028,7 @@ void Browser::Observe(int type,

void Browser::OnDevToolsDisabledChanged() {

if (profile_->GetPrefs()->GetBoolean(prefs::kDevToolsDisabled))

- content::DevToolsManager::GetInstance()->CloseAllClientHosts();

+ content::DevToolsAgentHost::DetachAllClients();

}

///////////////////////////////////////////////////////////////////////////////