content/shell/browser/shell.cc - Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell.cc

Issue 449043002: [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed DetachAllClients Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/browser/shell.cc

diff --git a/content/shell/browser/shell.cc b/content/shell/browser/shell.cc

index c63ff1553ed44bbe81970479ec60ab7c4dd08001..b10943df253c6d47eaa4cc733ac14c25e32fff26 100644

--- a/content/shell/browser/shell.cc

+++ b/content/shell/browser/shell.cc

@@ -12,7 +12,7 @@

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

-#include "content/public/browser/devtools_manager.h"

+#include "content/public/browser/devtools_agent_host.h"

#include "content/public/browser/navigation_controller.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/render_view_host.h"

@@ -114,7 +114,7 @@ Shell* Shell::CreateShell(WebContents* web_contents,

void Shell::CloseAllWindows() {

base::AutoReset<bool> auto_reset(&quit_message_loop_, false);

- DevToolsManager::GetInstance()->CloseAllClientHosts();

+ DevToolsAgentHost::DetachAllClients();

std::vector<Shell*> open_windows(windows_);

for (size_t i = 0; i < open_windows.size(); ++i)

open_windows[i]->Close();

« no previous file with comments | « content/public/browser/devtools_manager.h ('k') | content/shell/browser/shell_devtools_frontend.h » ('j') | no next file with comments »