Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Side by Side Diff: net/ftp/ftp_directory_listing_buffer_unittest.cc

Issue 449011: Make new FTP LIST parsing code more robust. (Closed)
Patch Set: fixes Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/data/ftp/dir-listing-vms-5.expected ('k') | net/ftp/ftp_directory_listing_parsers.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ftp/ftp_directory_listing_buffer.h" 5 #include "net/ftp/ftp_directory_listing_buffer.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/string_tokenizer.h" 10 #include "base/string_tokenizer.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "net/base/net_errors.h" 12 #include "net/base/net_errors.h"
13 #include "net/ftp/ftp_directory_listing_parsers.h" 13 #include "net/ftp/ftp_directory_listing_parsers.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace { 16 namespace {
17 17
18 TEST(FtpDirectoryListingBufferTest, Parse) { 18 TEST(FtpDirectoryListingBufferTest, Parse) {
19 const char* test_files[] = { 19 const char* test_files[] = {
20 "dir-listing-ls-1", 20 "dir-listing-ls-1",
21 "dir-listing-ls-1-utf8", 21 "dir-listing-ls-1-utf8",
22 "dir-listing-ls-2", 22 "dir-listing-ls-2",
23 "dir-listing-ls-3", 23 "dir-listing-ls-3",
24 "dir-listing-ls-4", 24 "dir-listing-ls-4",
25 "dir-listing-ls-5", 25 "dir-listing-ls-5",
26 "dir-listing-ls-6",
27 "dir-listing-ls-7",
28 "dir-listing-ls-8",
29 "dir-listing-ls-9",
30 "dir-listing-ls-10",
26 "dir-listing-windows-1", 31 "dir-listing-windows-1",
27 "dir-listing-windows-2", 32 "dir-listing-windows-2",
28 "dir-listing-vms-1", 33 "dir-listing-vms-1",
29 "dir-listing-vms-2", 34 "dir-listing-vms-2",
30 "dir-listing-vms-3", 35 "dir-listing-vms-3",
31 "dir-listing-vms-4", 36 "dir-listing-vms-4",
37 "dir-listing-vms-5",
32 }; 38 };
33 39
34 FilePath test_dir; 40 FilePath test_dir;
35 PathService::Get(base::DIR_SOURCE_ROOT, &test_dir); 41 PathService::Get(base::DIR_SOURCE_ROOT, &test_dir);
36 test_dir = test_dir.AppendASCII("net"); 42 test_dir = test_dir.AppendASCII("net");
37 test_dir = test_dir.AppendASCII("data"); 43 test_dir = test_dir.AppendASCII("data");
38 test_dir = test_dir.AppendASCII("ftp"); 44 test_dir = test_dir.AppendASCII("ftp");
39 45
40 for (size_t i = 0; i < arraysize(test_files); i++) { 46 for (size_t i = 0; i < arraysize(test_files); i++) {
41 SCOPED_TRACE(StringPrintf("Test[%" PRIuS "]: %s", i, test_files[i])); 47 SCOPED_TRACE(StringPrintf("Test[%" PRIuS "]: %s", i, test_files[i]));
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 EXPECT_EQ(hour, time_exploded.hour); 111 EXPECT_EQ(hour, time_exploded.hour);
106 EXPECT_EQ(minute, time_exploded.minute); 112 EXPECT_EQ(minute, time_exploded.minute);
107 EXPECT_EQ(0, time_exploded.second); 113 EXPECT_EQ(0, time_exploded.second);
108 EXPECT_EQ(0, time_exploded.millisecond); 114 EXPECT_EQ(0, time_exploded.millisecond);
109 } 115 }
110 EXPECT_FALSE(buffer.EntryAvailable()); 116 EXPECT_FALSE(buffer.EntryAvailable());
111 } 117 }
112 } 118 }
113 119
114 } // namespace 120 } // namespace
OLDNEW
« no previous file with comments | « net/data/ftp/dir-listing-vms-5.expected ('k') | net/ftp/ftp_directory_listing_parsers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698