Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 449007: Merge r33264 from the trunk to the 249 branch.... (Closed)

Created:
11 years ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam
Visibility:
Public.

Description

Merge r33264 from the trunk to the 249 branch. Add acknowledgement messages for PluginMsg_UpdateGeometry. On the Mac, use these acknowledgements to know when it's safe to dump old TransportDIBs in the renderer process. The Mac TransportDIB implementation uses base::SharedMemory, which cannot be disposed of if an inflight UpdateGeometry message refers to the shared memory file descriptor. BUG=27510, 26754 TEST=1. From bug 25710: a. Visit http://www.dkmsoftware.com/Yubotu.htm b. Click "Play Now" c. Resize vigorously. Expect: no sad plugin icon. 2. Test case from bug 26754 (affected machines only): a. Visit http://news.google.com/ b. Click the [+] to the left of a YouTube link. On affected machines, you'll get a sad plugin icon. c. Click the [+] to the left of a different YouTube link. Expect: no crash. 3. Test case from bug 26754 comment 9 (affected machines only): a. Have lots of bookmarks (import Safari defaults) b. Rightclick on bookmark bar, and choose "Open All Bookmarks" Expect: no crash. This change may not actually fix the third test case. Review URL: http://codereview.chromium.org/417005 TBR=mark@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -13 lines) Patch
M chrome/common/plugin_messages.h View 3 chunks +21 lines, -1 line 0 comments Download
M chrome/common/plugin_messages_internal.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 2 chunks +13 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 3 chunks +27 lines, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 6 chunks +73 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years ago (2009-11-30 03:29:11 UTC) #1
Mark Mentovai
11 years ago (2009-11-30 03:35:20 UTC) #2
autolgtm

Powered by Google App Engine
This is Rietveld 408576698