Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 449004: Merge r33241 to the 249 branch.... (Closed)

Created:
11 years ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge r33241 to the 249 branch. In-application Keystone ticket promotion. The concept of "ticket promotion" is added to the application when Keystone is in use. Ticket promotion is used to turn a user Keystone ticket, which Chrome normally establishes when it launches, into a system Keystone ticket, after successful user authentication and authorization. Having a system Keystone with a system ticket means that updates are applied with root privileges instead of user privileges, essentially eliminating the possibility that a user will fall off of the auto-update train because they can read and execute but not write the application. Two principles of promotion apply: - An application on a user ticket NEEDS promotion if it determines that it doesn't have permission to write to itself. Being on a user ticket, an update attempt would fail. - An application on a user ticket WANTS promotion if it already NEEDS promotion. Additionally, if it is installed in a system-wide location such as /Applications, it will WANT promotion, even if it does not NEED it. If promotion is needed, an info bar will show up on launch requesting it. This info bar works similarly to the default browser info bar: it has a "don't bother me again" button, it will only show up after the first launch, it won't disappear on navigation if the navigation happens very quickly, and it won't show itself if another info bar is up. This means that if both the default browser info bar and the promotion info bar have a shot at showing, only one will win. In my experience, each wins about half of the time. If promotion is needed, the update UI in the About window will be hidden. Checking for updates and offering to apply them doesn't make much sense when the update won't be able to install successfully. All of the auto-update machinery is still working in the background, but the About window UI is hidden. If promotion is wanted, the About window will contain a new button allowing the user to enter promotion. This gives access to the same promotion routine as the promotion info bar. It can be used even from an administrative account that is able to update the application without promotion. It's intended to be used by the system administrator of the family without requiring them to switch to one of the kids' accounts. BUG=16360 TEST=Exhaustively, please. Review URL: http://codereview.chromium.org/437053 TBR=mark@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1512 lines, -979 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +21 lines, -0 lines 0 comments Download
D chrome/app/keystone_glue.h View 1 chunk +0 lines, -118 lines 0 comments Download
D chrome/app/keystone_glue.mm View 1 chunk +0 lines, -389 lines 0 comments Download
D chrome/app/keystone_glue_unittest.mm View 1 chunk +0 lines, -182 lines 0 comments Download
M chrome/app/nibs/About.xib View 33 chunks +1086 lines, -228 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browser_init.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/browser_main_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/about_window_controller.h View 2 chunks +17 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller.mm View 12 chunks +340 lines, -51 lines 0 comments Download
M chrome/browser/cocoa/about_window_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/cocoa/authorization_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/authorization_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/keystone_glue.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/keystone_glue.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/keystone_glue_unittest.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/keystone_infobar.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/keystone_infobar.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/keystone_promote_postflight.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/keystone_promote_preflight.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/cocoa/scoped_authorizationref.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome.gyp View 9 chunks +29 lines, -10 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years ago (2009-11-28 23:03:35 UTC) #1
Mark Mentovai
11 years ago (2009-11-28 23:10:15 UTC) #2
autolgtm

Powered by Google App Engine
This is Rietveld 408576698