Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 448973003: Gallery: Fix undo of cropping images. (Closed)

Created:
6 years, 4 months ago by hirono
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Gallery: Fix undo of cropping images. The CL also updates the browser test to handle the case. BUG=401314 TEST=manually and run the test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288300

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/photo_editor.js View 3 chunks +14 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 4 months ago (2014-08-07 05:26:59 UTC) #1
yoshiki
lgtm https://codereview.chromium.org/448973003/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js File chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js (right): https://codereview.chromium.org/448973003/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js#newcode152 chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js:152: * @param {function():Promise} callback Callback returns a promise. ...
6 years, 4 months ago (2014-08-07 09:28:55 UTC) #2
hirono
Thank you! https://codereview.chromium.org/448973003/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js File chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js (right): https://codereview.chromium.org/448973003/diff/1/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js#newcode152 chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/test_util.js:152: * @param {function():Promise} callback Callback returns a ...
6 years, 4 months ago (2014-08-08 02:35:28 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 4 months ago (2014-08-08 02:35:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/448973003/20001
6 years, 4 months ago (2014-08-08 02:37:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-08 06:43:16 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 10:11:37 UTC) #7
Message was sent while issue was closed.
Change committed as 288300

Powered by Google App Engine
This is Rietveld 408576698