Issue 448973002: Close a QUIC connection if there are too many unfinished streams being

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 448973002: Close a QUIC connection if there are too many unfinished streams being (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)

Modified:
6 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade

Base URL:
https://chromium.googlesource.com/chromium/src.git@Remove_unused_version_argument_72559549

Project:
chromium

Visibility:
Public.

More Reviews

Description

Close a QUIC connection if there are too many unfinished streams being tracked in the locally closed map. Protected behind FLAGS_close_quic_connection_unfinished_streams (defaults to false). Merge internal change: 72561976 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -1 line)			Patch
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/quic/quic_protocol.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_session.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/quic/quic_session_test.cc	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	net/quic/quic_utils.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ramant (doing other things)

On 2014/08/07 03:58:29, ramant wrote: Hi Ryan and Robbie, Defaulted FLAGS_close_quic_connection_unfinished_streams to false. Will set ...

6 years, 4 months ago (2014-08-07 04:00:58 UTC) #2

Robbie Shade

On 2014/08/07 04:00:58, ramant wrote: > On 2014/08/07 03:58:29, ramant wrote: > > Hi Ryan ...

6 years, 4 months ago (2014-08-07 13:16:22 UTC) #3

lgtm

Expand Messages | Collapse Messages