Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 448953003: Fix IndexedDB tests to use a TestBrowserThreadBundle (Closed)

Created:
6 years, 4 months ago by Ryan Sleevi
Modified:
6 years, 4 months ago
Reviewers:
cmumford
CC:
chromium-reviews, jam, alecflett, darin-cc_chromium.org, cmumford, dgrogan, jsbell+idb_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix IndexedDB tests to use a TestBrowserThreadBundle BUG=395358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290774

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ryan Sleevi
cmumford: PTAL The reason this is still failing is because TestURLRequestContext is initialized before thread_bundle_ ...
6 years, 4 months ago (2014-08-07 03:00:16 UTC) #1
cmumford
lgtm https://codereview.chromium.org/448953003/diff/1/content/browser/indexed_db/indexed_db_backing_store_unittest.cc File content/browser/indexed_db/indexed_db_backing_store_unittest.cc (right): https://codereview.chromium.org/448953003/diff/1/content/browser/indexed_db/indexed_db_backing_store_unittest.cc#newcode332 content/browser/indexed_db/indexed_db_backing_store_unittest.cc:332: content::TestBrowserThreadBundle thread_bundle_; Is it worth a comment that ...
6 years, 4 months ago (2014-08-07 15:15:27 UTC) #2
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 4 months ago (2014-08-20 02:53:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/448953003/40001
6 years, 4 months ago (2014-08-20 02:54:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 04:00:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 04:50:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/527)
6 years, 4 months ago (2014-08-20 04:50:35 UTC) #7
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 4 months ago (2014-08-20 04:53:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/448953003/40001
6 years, 4 months ago (2014-08-20 04:54:28 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 05:57:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290774

Powered by Google App Engine
This is Rietveld 408576698