Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: tests/compiler/dart2js/mirror_helper_test.dart

Issue 448943004: Refactor and simplify the dart2dart renamer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix minifying name generation Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/mirror_helper_test.dart
diff --git a/tests/compiler/dart2js/mirror_helper_test.dart b/tests/compiler/dart2js/mirror_helper_test.dart
index 80888b890ec4fe200795aa2358deecf19dce1707..68fe2575363cda62d0bce467fd447e26dc8031bd 100644
--- a/tests/compiler/dart2js/mirror_helper_test.dart
+++ b/tests/compiler/dart2js/mirror_helper_test.dart
@@ -42,8 +42,9 @@ void testWithMirrorRenaming({bool minify}) {
DartBackend backend = compiler.backend;
MirrorRenamer mirrorRenamer = backend.mirrorRenamer;
- Map<Node, String> renames = backend.renames;
- Map<LibraryElement, String> imports = backend.imports;
+ Map<Node, String> renames = backend.placeholderRenamer.renames;
+ Set<LibraryElement> imports =
+ backend.placeholderRenamer.platformImports;
FunctionExpression node = backend.memberNodes.values.first.first;
Block block = node.body;
@@ -54,7 +55,7 @@ void testWithMirrorRenaming({bool minify}) {
renames[send.selector]);
Expect.equals("",
renames[send.receiver]);
- Expect.equals(1, imports.keys.length);
+ Expect.equals(1, imports.length);
}));
}
@@ -63,17 +64,16 @@ void testWithoutMirrorRenaming({bool minify}) {
then((Compiler compiler) {
DartBackend backend = compiler.backend;
- Map<Node, String> renames = backend.renames;
- Map<LibraryElement, String> imports = backend.imports;
-
+ Map<Node, String> renames = backend.placeholderRenamer.renames;
+ Set<LibraryElement> imports =
+ backend.placeholderRenamer.platformImports;
FunctionExpression node = backend.memberNodes.values.first.first;
Block block = node.body;
ExpressionStatement getNameFunctionNode = block.statements.nodes.head;
Send send = getNameFunctionNode.expression;
Expect.isFalse(renames.containsKey(send.selector));
- Expect.isFalse(renames.containsKey(send.receiver));
- Expect.equals(1, imports.keys.length);
+ Expect.equals(1, imports.length);
}));
}

Powered by Google App Engine
This is Rietveld 408576698