sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart - Issue 448943004: Refactor and simplify the dart2dart renamer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart

Issue 448943004: Refactor and simplify the dart2dart renamer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rely (almost) only on Entity from renamer. Improve handling of privates and constructors. Avoid sor… Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart » ('j') | sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart

diff --git a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart

index 1e708c4e8bbcd3decbd47cb0706df6fc3374ca25..ffee90c38186337b450831258aa3de0b5de20ae8 100644

--- a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart

+++ b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart

@@ -110,6 +110,10 @@ class IrBuilderTask extends CompilerTask {

if (function is ConstructorElement && function.isRedirectingFactory) {

return false;

}

+ // TODO(kmillikin,sigurdm): support syntax for factory constructors

+ if (function is ConstructorElement && function.isFactoryConstructor) {

+ return false;

+ }

return true;

}