Refactor and simplify the dart2dart renamer.

tests/compiler/dart2js/backend_dart/dart_backend_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "package:expect/expect.dart";
 import 'dart:async';
 import "package:async_helper/async_helper.dart";
 import '../mock_compiler.dart';
 import '../mock_libraries.dart';
 import 'package:compiler/compiler.dart';
@@ skipping 323 matching lines @@
 var globalVar;
 var globalVarInitialized = 6;
 var globalVarInitialized2 = 7;
 class A {
   A() {}
   A.fromFoo() {}
   static staticfoo() {}
   foo() {}
   static const field = 5;
 }
-A_globalfoo() {}
-var A_globalVar;
-var A_globalVarInitialized = 6;
-var A_globalVarInitialized2 = 7;
+globalfoo_A() {}
+var globalVar_A;
+var globalVarInitialized_A = 6;
+var globalVarInitialized2_A = 7;
 class A_A {
   A_A() {}
-  A_A.A_fromFoo() {}
-  static A_staticfoo() {}
+  A_A.fromFoo_A() {}
+  static staticfoo_A() {}
   foo() {}
-  static const A_field = 5;
+  static const field_A = 5;
 }
 main() {
-  A_globalVar;
-  A_globalVarInitialized;
-  A_globalVarInitialized2;
-  A_globalfoo();
-  A_A.A_field;
-  A_A.A_staticfoo();
+  globalVar_A;
+  globalVarInitialized_A;
+  globalVarInitialized2_A;
+  globalfoo_A();
+  A_A.field_A;
+  A_A.staticfoo_A();
   new A_A();
-  new A_A.A_fromFoo();
+  new A_A.fromFoo_A();
   new A_A().foo();
   globalVar;
   globalVarInitialized;
   globalVarInitialized2;
   globalfoo();
   A.field;
   A.staticfoo();
   new A();
   new A.fromFoo();
   new A().foo();
@@ skipping 116 matching lines @@
   a = getA();
   topfoo();
   mylib.topfoo();
 }
 ''';
   var expectedResult = '''
 topfoo() {}
 class A {
   foo() {}
 }
-A_topfoo() {
+topfoo_A() {
   var x = 5;
 }
 class A_A {
   num foo() {}
   A_A.fromFoo() {}
   A myliba;
   List<A_A> mylist;
 }
 A getA() => null;
 main() {
   var a = new A();
   a.foo();
   var b = new A_A.fromFoo();
   b.foo();
   var GREATVAR = b.myliba;
   b.mylist;
   a = getA();
-  A_topfoo();
+  topfoo_A();
   topfoo();
 }
 ''';
   testDart2DartWithLibrary(mainSrc, librarySrc,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testClassExtendsWithArgs() {
   testDart2Dart('''
 main() {
@@ skipping 29 matching lines @@
   topgetset;
   topgetset = 6;
 
   mylib.topgetset;
   mylib.topgetset = 5;
 }
 ''';
   var expectedResult = '''
 get topgetset => 5;
 set topgetset(arg) {}
-get A_topgetset => 6;
-set A_topgetset(arg) {}
+get topgetset_A => 6;
+set topgetset_A(arg) {}
 main() {
-  A_topgetset;
-  A_topgetset = 6;
+  topgetset_A;
+  topgetset_A = 6;
   topgetset;
   topgetset = 5;
 }
 ''';
   testDart2DartWithLibrary(mainSrc, librarySrc,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testFieldTypeOutput() {
   testDart2Dart('''
@@ skipping 73 matching lines @@
   new mylib.T();
 }
 ''';
   var expectedResult = '''
 typedef void MyFunction<T extends num>(T arg);
 class T {}
 class B<T> {}
 class A<T> extends B<T> {
   T f;
 }
-typedef void A_MyFunction<A_T extends num>(A_T arg);
-class A_T {}
-class A_B<A_T> {}
-class A_A<A_T> extends A_B<A_T> {
-  A_T f;
+typedef void MyFunction_A<T_A extends num>(T_A arg);
+class T_A {}
+class B_A<T_A> {}
+class A_A<T_A> extends B_A<T_A> {
+  T_A f;
 }
 main() {
-  A_MyFunction myf1;
+  MyFunction_A myf1;
   MyFunction myf2;
   new A_A<int>().f;
-  new A_T();
+  new T_A();
   new A<int>().f;
   new T();
 }
 ''';
   testDart2DartWithLibrary(mainSrc, librarySrc,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testClassTypeArgumentBound() {
   var librarySrc = '''
@@ skipping 10 matching lines @@
 class A<T extends I> {}
 
 main() {
   new A();
   new mylib.A();
 }
 ''';
   var expectedResult = '''
 class I {}
 class A<T extends I> {}
-class A_I {}
-class A_A<A_T extends A_I> {}
+class I_A {}
+class A_A<T_A extends I_A> {}
 main() {
   new A_A();
   new A();
 }
 ''';
   testDart2DartWithLibrary(mainSrc, librarySrc,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testDoubleMains() {
   var librarySrc = '''
 library mylib;
 main() {}
 ''';
   var mainSrc = '''
 import 'mylib.dart' as mylib;
 main() {
   mylib.main();
 }
 ''';
   var expectedResult = '''
-A_main() {}
+main_A() {}
 main() {
-  A_main();
+  main_A();
 }
 ''';
   testDart2DartWithLibrary(mainSrc, librarySrc,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testStaticAccessIoLib() {
   var src = '''
 import 'dart:io';
 
 main() {
   Platform.operatingSystem;
 }
 ''';
   var expectedResult = '''
-import "dart:io" as p;
+import "dart:io";
 main() {
-  p.Platform.operatingSystem;
+  Platform.operatingSystem;
 }
 ''';
   testDart2Dart(src,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testMinification() {
   var src = '''
 class ClassWithVeryVeryLongName {}
 main() {
@@ skipping 83 matching lines @@
 
 class A {
   static String get userAgent => window.navigator.userAgent;
 }
 
 main() {
   A.userAgent;
 }
 ''';
   var expectedResult = '''
-import "dart:html" as p;
+import "dart:html";
 class A {
-  static String get A_userAgent => p.window.navigator.userAgent;
+  static String get userAgent_A => window.navigator.userAgent;
 }
 main() {
-  A.A_userAgent;
+  A.userAgent_A;
 }
 ''';
   testDart2Dart(src,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testConflictsWithCoreLib() {
   var src = '''
 import 'dart:core' as fisk;
 
 print(x) { throw 'fisk'; }
 
 main() {
   fisk.print('corelib');
   print('local');
 }
 ''';
   var expectedResult = """
-A_print(x) {
+print_A(x) {
   throw 'fisk';
 }
 main() {
   print('corelib');
-  A_print('local');
+  print_A('local');
 }
 """;
   testDart2Dart(src,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 testUnresolvedNamedConstructor() {
   var src = '''
 class A {
   A() {}
 }
 
 main() {
   new A();
   new A.named();
 }
 ''';
   var expectedResult = """
 class A {
   A() {}
 }
 main() {
   new A();
-  new A_Unresolved();
+  new Unresolved_A();
 }
 """;
   testDart2Dart(src,
       continuation: (String result) { Expect.equals(expectedResult, result); });
 }
 
 main() {
   testSimpleFileUnparse();
   testTopLevelField();
   testSimpleTopLevelClass();
@@ skipping 16 matching lines @@
   testStaticAccessIoLib();
   testLocalFunctionPlaceholder();
   testMinification();
   testClosureLocalsMinified();
   testParametersMinified();
   testDeclarationTypePlaceholders();
   testPlatformLibraryMemberNamesAreFixed();
   testConflictsWithCoreLib();
   testUnresolvedNamedConstructor();
 }