Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 448923003: Clean up useless code in InputMethodManagerImpl. (Closed)

Created:
6 years, 4 months ago by Shu Chen
Modified:
6 years, 4 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up useless code in InputMethodManagerImpl. BUG=342336 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288378

Patch Set 1 #

Patch Set 2 : rebased. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Shu Chen
Nona/Alex, can you please review this cl? Thanks
6 years, 4 months ago (2014-08-07 01:04:23 UTC) #1
Alexander Alekseev
lgtm
6 years, 4 months ago (2014-08-07 15:13:22 UTC) #2
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 4 months ago (2014-08-08 14:02:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/448923003/20001
6 years, 4 months ago (2014-08-08 14:04:36 UTC) #4
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 4 months ago (2014-08-08 15:29:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/448923003/40001
6 years, 4 months ago (2014-08-08 15:30:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-08 16:45:52 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 16:50:05 UTC) #8
Message was sent while issue was closed.
Change committed as 288378

Powered by Google App Engine
This is Rietveld 408576698