Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: Source/core/dom/NodeRenderingTraversal.cpp

Issue 448893003: Add an assertion to make sure NodeRenderingTraversal::parent is called after the distribution resul… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update styleForPage Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/NodeRenderingTraversal.cpp
diff --git a/Source/core/dom/NodeRenderingTraversal.cpp b/Source/core/dom/NodeRenderingTraversal.cpp
index a25c01058231c2fbb6c8c08e1befa5cad1c86d1c..38e164b2bebcaca439189e4265bad06a4b13e166 100644
--- a/Source/core/dom/NodeRenderingTraversal.cpp
+++ b/Source/core/dom/NodeRenderingTraversal.cpp
@@ -54,10 +54,8 @@ void ParentDetails::didTraverseInsertionPoint(const InsertionPoint* insertionPoi
ContainerNode* parent(const Node* node, ParentDetails* details)
{
- // FIXME: We should probably ASSERT(!node->document().childNeedsDistributionRecalc()) here, but
- // a bunch of things use NodeRenderingTraversal::parent in places where that looks like it could
- // be false.
ASSERT(node);
+ ASSERT(!node->document().childNeedsDistributionRecalc());
if (isActiveInsertionPoint(*node))
return 0;
ComposedTreeWalker walker(node, ComposedTreeWalker::CanStartFromShadowBoundary);
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698