Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: Source/core/css/resolver/ElementResolveContext.cpp

Issue 448893003: Add an assertion to make sure NodeRenderingTraversal::parent is called after the distribution resul… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix crashes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/NodeRenderingTraversal.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 25 matching lines...) Expand all
36 , m_elementLinkState(NotInsideLink) 36 , m_elementLinkState(NotInsideLink)
37 , m_distributedToInsertionPoint(false) 37 , m_distributedToInsertionPoint(false)
38 { 38 {
39 } 39 }
40 40
41 ElementResolveContext::ElementResolveContext(Element& element) 41 ElementResolveContext::ElementResolveContext(Element& element)
42 : m_element(&element) 42 : m_element(&element)
43 , m_elementLinkState(element.document().visitedLinkState().determineLinkStat e(element)) 43 , m_elementLinkState(element.document().visitedLinkState().determineLinkStat e(element))
44 , m_distributedToInsertionPoint(false) 44 , m_distributedToInsertionPoint(false)
45 { 45 {
46 element.document().updateDistributionForNodeIfNeeded(&element);
esprehn 2014/08/13 09:10:51 This is not correct, you shouldn't be updating dis
46 NodeRenderingTraversal::ParentDetails parentDetails; 47 NodeRenderingTraversal::ParentDetails parentDetails;
47 m_parentNode = NodeRenderingTraversal::parent(&element, &parentDetails); 48 m_parentNode = NodeRenderingTraversal::parent(&element, &parentDetails);
48 m_distributedToInsertionPoint = parentDetails.insertionPoint(); 49 m_distributedToInsertionPoint = parentDetails.insertionPoint();
49 50
50 const Document& document = element.document(); 51 const Document& document = element.document();
51 Node* documentElement = document.documentElement(); 52 Node* documentElement = document.documentElement();
52 RenderStyle* documentStyle = document.renderStyle(); 53 RenderStyle* documentStyle = document.renderStyle();
53 m_rootElementStyle = documentElement && element != documentElement ? documen tElement->renderStyle() : documentStyle; 54 m_rootElementStyle = documentElement && element != documentElement ? documen tElement->renderStyle() : documentStyle;
54 if (!m_rootElementStyle) 55 if (!m_rootElementStyle)
55 m_rootElementStyle = documentStyle; 56 m_rootElementStyle = documentStyle;
56 } 57 }
57 58
58 } // namespace blink 59 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/NodeRenderingTraversal.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698