Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 448883002: Fix permission regression where warnings aren't shown in the dialog (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix permission regression where warnings aren't shown in the dialog A regression was introduced in r275142 causing the permissions dialog to not show permissions. Obviously very bad. Fixed, and added a regression test. BUG=397900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -22 lines) Patch
M chrome/browser/extensions/extension_install_prompt.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 chunk +12 lines, -16 lines 0 comments Download
A chrome/browser/extensions/extension_install_prompt_unittest.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/permissions/permissions_data.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/permissions/permissions_data.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Devlin
6 years, 4 months ago (2014-08-06 22:44:43 UTC) #1
Yoyo Zhou
LGTM
6 years, 4 months ago (2014-08-06 23:03:03 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-07 13:29:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/448883002/1
6 years, 4 months ago (2014-08-07 13:30:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 16:48:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 18:06:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3385)
6 years, 4 months ago (2014-08-07 18:06:40 UTC) #7
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-07 18:11:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/448883002/1
6 years, 4 months ago (2014-08-07 18:17:21 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 18:42:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-07 20:51:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/3441)
6 years, 4 months ago (2014-08-07 20:51:34 UTC) #12
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-07 20:59:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/448883002/1
6 years, 4 months ago (2014-08-07 21:07:19 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-07 21:48:40 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 00:44:38 UTC) #16
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
6 years, 4 months ago (2014-08-08 00:44:48 UTC) #17
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-08 15:45:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/448883002/1
6 years, 4 months ago (2014-08-08 15:46:49 UTC) #19
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 15:48:27 UTC) #20
Message was sent while issue was closed.
Change committed as 288365

Powered by Google App Engine
This is Rietveld 408576698