Issue 448823002: Docserver: Remove instances of _GetAsyncFetchCallback()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 448823002: Docserver: Remove instances of _GetAsyncFetchCallback() (Closed)

Created:
6 years, 4 months ago by ahernandez

Modified:
6 years, 4 months ago

Reviewers:
Yoyo Zhou, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Docserver: Remove instances of _GetAsyncFetchCallback() NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288287

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+102 lines, -122 lines)			Patch
M	chrome/common/extensions/docs/server2/patched_file_system.py	View	2 chunks	+20 lines, -30 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/rietveld_patcher.py	View	2 chunks	+41 lines, -49 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/subversion_file_system.py	View	2 chunks	+41 lines, -43 lines	0 comments	Download

Total messages: 4 (0 generated)

ahernandez

I believe Ben previously mentioned that the _GetAsyncCallback() pattern is old, and I personally think ...

6 years, 4 months ago (2014-08-06 20:13:59 UTC) #1

ahernandez

The CQ bit was checked by ahernandez.miralles@gmail.com

6 years, 4 months ago (2014-08-07 23:32:30 UTC) #3

Message was sent while issue was closed.

Change committed as 288287