Non-SFI NaCl: Filter out all optimization flags for libc_free.c

Non-SFI NaCl: Filter out all optimization flags for libc_free.c

BUG=400989
TEST=trybots

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288002

[hamaji, 2014-08-06 19:48:39]

Note: I didn't know -Ofast but gcc seems to support it. It seems clang used to
behave differently with -O4
(http://lists.cs.uiuc.edu/pipermail/llvm-announce/2014-January/000049.html)

[Mark Seaborn, 2014-08-06 20:51:21]

LGTM

https://codereview.chromium.org/448803003/diff/1/chrome/test/data/nacl/nacl_t...
File chrome/test/data/nacl/nacl_test_data.gyp (right):

https://codereview.chromium.org/448803003/diff/1/chrome/test/data/nacl/nacl_t...
chrome/test/data/nacl/nacl_test_data.gyp:1184: '-O1',
FWIW, Gyp does support regexps.  You could probably use:

'cflags/': [['exclude', '$-O']], # Strip -O2, -Os etc.

See https://code.google.com/p/gyp/wiki/InputFormatReference#List_Filters

[hamaji, 2014-08-06 22:04:12]

https://codereview.chromium.org/448803003/diff/1/chrome/test/data/nacl/nacl_t...
File chrome/test/data/nacl/nacl_test_data.gyp (right):

https://codereview.chromium.org/448803003/diff/1/chrome/test/data/nacl/nacl_t...
chrome/test/data/nacl/nacl_test_data.gyp:1184: '-O1',
On 2014/08/06 20:51:21, Mark Seaborn wrote:
> FWIW, Gyp does support regexps.  You could probably use:
> 
> 'cflags/': [['exclude', '$-O']], # Strip -O2, -Os etc.
> 
> See https://code.google.com/p/gyp/wiki/InputFormatReference#List_Filters

You meant ^-O ? Done.

[Mark Seaborn, 2014-08-07 01:49:17]

On 2014/08/06 22:04:12, hamaji wrote:
>
https://codereview.chromium.org/448803003/diff/1/chrome/test/data/nacl/nacl_t...
> File chrome/test/data/nacl/nacl_test_data.gyp (right):
> 
>
https://codereview.chromium.org/448803003/diff/1/chrome/test/data/nacl/nacl_t...
> chrome/test/data/nacl/nacl_test_data.gyp:1184: '-O1',
> On 2014/08/06 20:51:21, Mark Seaborn wrote:
> > FWIW, Gyp does support regexps.  You could probably use:
> > 
> > 'cflags/': [['exclude', '$-O']], # Strip -O2, -Os etc.
> > 
> > See https://code.google.com/p/gyp/wiki/InputFormatReference#List_Filters
> 
> You meant ^-O ? Done.

Yep.  LGTM.

[hamaji, 2014-08-07 06:39:13]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-08-07 06:41:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hamaji@chromium.org/448803003/20001

[commit-bot: I haz the power, 2014-08-07 07:56:05]

Change committed as 288002