Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: src/core/SkRecords.h

Issue 448793004: add drawPicture variant that takes a matrix and paint (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkRecords.h
diff --git a/src/core/SkRecords.h b/src/core/SkRecords.h
index 1de16754528c408ec195657ff5fd8c60240a19f3..a9807ae3ab7542dbcc6c017eefecedda9d49882e 100644
--- a/src/core/SkRecords.h
+++ b/src/core/SkRecords.h
@@ -17,14 +17,11 @@ public:
SkPictureBox(const SkPictureBox& src) : fObj(SkRef(src.fObj)) {}
mtklein 2014/08/07 21:25:20 Try removing this too? I don't think we need it.
reed1 2014/08/08 13:57:29 Done.
~SkPictureBox() { fObj->unref(); }
- SkPictureBox& operator=(const SkPictureBox& src) {
- SkRefCnt_SafeAssign(fObj, src.fObj);
- return *this;
- }
-
operator const SkPicture*() const { return fObj; }
private:
+ SkPictureBox& operator=(const SkPictureBox& src);
+
const SkPicture* fObj;
};
@@ -238,7 +235,7 @@ RECORD2(DrawOval, SkPaint, paint, SkRect, oval);
RECORD1(DrawPaint, SkPaint, paint);
RECORD2(DrawPath, SkPaint, paint, SkPath, path);
RECORD2(DrawPatch, SkPaint, paint, SkPatch, patch);
-RECORD1(DrawPicture, SkPictureBox, picture);
+RECORD3(DrawPicture, Optional<SkPaint>, paint, SkPictureBox, picture, Optional<SkMatrix>, matrix);
RECORD4(DrawPoints, SkPaint, paint, SkCanvas::PointMode, mode, size_t, count, SkPoint*, pts);
RECORD4(DrawPosText, SkPaint, paint,
PODArray<char>, text,

Powered by Google App Engine
This is Rietveld 408576698