add drawPicture variant that takes a matrix and paint

src/core/SkCanvas.cpp

 /*
  * Copyright 2008 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkCanvas.h"
 #include "SkBitmapDevice.h"
@@ skipping 2379 matching lines @@
 ///////////////////////////////////////////////////////////////////////////////
 void SkCanvas::EXPERIMENTAL_optimize(const SkPicture* picture) {
     SkBaseDevice* device = this->getDevice();
     if (NULL != device) {
         device->EXPERIMENTAL_optimize(picture);
     }
 }
 
 void SkCanvas::drawPicture(const SkPicture* picture) {
     if (NULL != picture) {
-        this->onDrawPicture(picture);
+        this->onDrawPicture(picture, NULL, NULL);
     }
 }
 
-void SkCanvas::onDrawPicture(const SkPicture* picture) {
-    SkASSERT(NULL != picture);
+void SkCanvas::drawPicture(const SkPicture* picture, const SkMatrix* matrix, const SkPaint* paint) {
+    if (NULL != picture) {
+        if (matrix && matrix->isIdentity()) {

[bsalomon, 2014/08/08 13:49:38]

What is this saving? Don't most of our matrix methods have shortcuts for I?
Invert and concat do.

[reed1, 2014/08/08 13:57:29]

save()/restore()

[bsalomon, 2014/08/08 13:59:42]

Ah, that makes sense!

+            matrix = NULL;
+        }
+        this->onDrawPicture(picture, matrix, paint);
+    }
+}
+
+void SkCanvas::onDrawPicture(const SkPicture* pic, const SkMatrix* matrix, const SkPaint* paint) {
+    SkASSERT(NULL != pic);

[robertphillips, 2014/08/08 14:59:53]

I think the save/saveLayer needs to be moved to after the device's attempt since
in that case the backend will take care of it itself.

+

[robertphillips, 2014/08/08 14:59:53]

Move bounds computation into "if (paint) {" block ?

+    SkRect bounds = SkRect::MakeWH(SkIntToScalar(pic->width()), SkIntToScalar(pic->height()));
+    if (matrix) {
+        matrix->mapRect(&bounds);
+    }
+
+    SkAutoCanvasRestore acr(this, false);
+
+    if (paint) {
+        this->SkCanvas::saveLayer(&bounds, paint);
+    } else if (matrix) {
+        this->SkCanvas::save();
+    }
+
+    if (matrix) {
+        this->SkCanvas::concat(*matrix);
+    }
 
     SkBaseDevice* device = this->getTopDevice();
     if (NULL != device) {
         // Canvas has to first give the device the opportunity to render
         // the picture itself.

[robertphillips, 2014/08/08 15:01:18]

Can we add matrix & paint to this too?

-        if (device->EXPERIMENTAL_drawPicture(this, picture)) {
+        if (device->EXPERIMENTAL_drawPicture(this, pic)) {
             return; // the device has rendered the entire picture
         }
     }
-
-    picture->draw(this);
+    pic->draw(this);
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 ///////////////////////////////////////////////////////////////////////////////
 
 SkCanvas::LayerIter::LayerIter(SkCanvas* canvas, bool skipEmptyClips) {
     SK_COMPILE_ASSERT(sizeof(fStorage) >= sizeof(SkDrawIter), fStorage_too_small);
 
     SkASSERT(canvas);
 
@@ skipping 77 matching lines @@
     if (!supported_for_raster_canvas(info)) {
         return NULL;
     }
 
     SkBitmap bitmap;
     if (!bitmap.installPixels(info, pixels, rowBytes)) {
         return NULL;
     }
     return SkNEW_ARGS(SkCanvas, (bitmap));
 }