[Most Visited] Support two additional parameters in the iframes

[Most Visited] Support two additional parameters in the iframes

To support the redesign, support two new parameters: ta and tf, which stand for text-align and text fade. For text fade, a linear gradient is created to gently fade the text overflow.

BUG=400332, 400341
TBR=jered
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288234

[Mathieu, 2014-08-06 19:53:41]

Hello, 

This is ready for review (still sorting out PRESUBMIT.py issue with
-webkit-linear-gradient, as linear-gradient doesn't work as we would like).

Jered: Change to iframe API to support new styles
Sam: Overall CL 

Thanks!

[Mathieu, 2014-08-06 20:01:50]

On 2014/08/06 19:53:41, Mathieu Perreault wrote:
> Hello, 
> 
> This is ready for review (still sorting out PRESUBMIT.py issue with
> -webkit-linear-gradient, as linear-gradient doesn't work as we would like).
> 
> Jered: Change to iframe API to support new styles
> Sam: Overall CL 
> 
> Thanks!

Now using the correct gradient thanks to jchaffraix@!

[huangs, 2014-08-06 20:17:43]

lgtm

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/local_ntp/most_visited_thumbnail.js (right):

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
chrome/browser/resources/local_ntp/most_visited_thumbnail.js:27: params,
data.url, data.title, undefined, data.direciton,
TYPO: direciton

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/local_ntp/most_visited_title.css (right):

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
chrome/browser/resources/local_ntp/most_visited_title.css:10: /* The values for
text-align and text-overflow can be overridden in JS. */
I'd prefer to put this right beside each item:

  text-align: center;  /* Can be overridden in JS. */
  text-overflow: ellipsis;   /* Can be overridden in JS. */

[Mathieu, 2014-08-06 20:19:21]

Thanks!

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/local_ntp/most_visited_thumbnail.js (right):

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
chrome/browser/resources/local_ntp/most_visited_thumbnail.js:27: params,
data.url, data.title, undefined, data.direciton,
On 2014/08/06 20:17:43, huangs1 wrote:
> TYPO: direciton

Done.

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/local_ntp/most_visited_title.css (right):

https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources...
chrome/browser/resources/local_ntp/most_visited_title.css:10: /* The values for
text-align and text-overflow can be overridden in JS. */
On 2014/08/06 20:17:43, huangs1 wrote:
> I'd prefer to put this right beside each item:
> 
>   text-align: center;  /* Can be overridden in JS. */
>   text-overflow: ellipsis;   /* Can be overridden in JS. */

Done.

[Mathieu, 2014-08-07 14:41:01]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-08-07 14:41:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/448793003/40001

[Jered, 2014-08-07 18:13:06]

On 2014/08/07 14:41:58, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/mathp@chromium.org/448793003/40001

lgtm

[commit-bot: I haz the power, 2014-08-07 19:38:38]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-08 06:45:10]

Change committed as 288234