Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 448793003: [Most Visited] Support two additional parameters in the iframes (Closed)

Created:
6 years, 4 months ago by Mathieu
Modified:
6 years, 4 months ago
Reviewers:
huangs, Jered
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, arv+watch_chromium.org, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Julien - ping for review
Project:
chromium
Visibility:
Public.

Description

[Most Visited] Support two additional parameters in the iframes To support the redesign, support two new parameters: ta and tf, which stand for text-align and text fade. For text fade, a linear gradient is created to gently fade the text overflow. BUG=400332, 400341 TBR=jered TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288234

Patch Set 1 #

Patch Set 2 : changed gradient to valid one #

Total comments: 4

Patch Set 3 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M chrome/browser/resources/local_ntp/most_visited_thumbnail.js View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_title.css View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_title.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/local_ntp/most_visited_util.js View 1 3 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mathieu
Hello, This is ready for review (still sorting out PRESUBMIT.py issue with -webkit-linear-gradient, as linear-gradient ...
6 years, 4 months ago (2014-08-06 19:53:41 UTC) #1
Mathieu
On 2014/08/06 19:53:41, Mathieu Perreault wrote: > Hello, > > This is ready for review ...
6 years, 4 months ago (2014-08-06 20:01:50 UTC) #2
huangs
lgtm https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources/local_ntp/most_visited_thumbnail.js File chrome/browser/resources/local_ntp/most_visited_thumbnail.js (right): https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources/local_ntp/most_visited_thumbnail.js#newcode27 chrome/browser/resources/local_ntp/most_visited_thumbnail.js:27: params, data.url, data.title, undefined, data.direciton, TYPO: direciton https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources/local_ntp/most_visited_title.css ...
6 years, 4 months ago (2014-08-06 20:17:43 UTC) #3
Mathieu
Thanks! https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources/local_ntp/most_visited_thumbnail.js File chrome/browser/resources/local_ntp/most_visited_thumbnail.js (right): https://codereview.chromium.org/448793003/diff/20001/chrome/browser/resources/local_ntp/most_visited_thumbnail.js#newcode27 chrome/browser/resources/local_ntp/most_visited_thumbnail.js:27: params, data.url, data.title, undefined, data.direciton, On 2014/08/06 20:17:43, ...
6 years, 4 months ago (2014-08-06 20:19:21 UTC) #4
Mathieu
The CQ bit was checked by mathp@chromium.org
6 years, 4 months ago (2014-08-07 14:41:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mathp@chromium.org/448793003/40001
6 years, 4 months ago (2014-08-07 14:41:58 UTC) #6
Jered
On 2014/08/07 14:41:58, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-08-07 18:13:06 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-07 19:38:38 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 06:45:10 UTC) #9
Message was sent while issue was closed.
Change committed as 288234

Powered by Google App Engine
This is Rietveld 408576698